1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • New Defects reported by Coverity Scan for Synchronet

    From scan-admin@coverity.com@VERT to All on Sun Aug 10 14:15:47 2025
    ----==_mimepart_6898a9938c063_f22012b538a7b399c12567
    Content-Type: text/plain; charset=us-ascii
    Content-Transfer-Encoding: 7bit

    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 583942: High impact quality (Y2K38_SAFETY)
    /userdat.c: 3171 in loginuserdat()


    _______________________________________________________________________________ ______________
    *** CID 583942: High impact quality (Y2K38_SAFETY)
    /userdat.c: 3171 in loginuserdat()
    3165 if (protocol != NULL)
    3166 SAFECOPY(user->connection, protocol);
    3167 if (hostname != NULL)
    3168 SAFECOPY(user->comp, hostname);
    3169 if (ipaddr != NULL)
    3170 SAFECOPY(user->ipaddr, ipaddr);
    CID 583942: High impact quality (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "logontime" is cast to "time32_t".
    3171 user->logontime = logontime;
    3172
    3173 return putuserdat(cfg, user);
    3174 }
    3175
    3176 /****************************************************************************/


    _______________________________________________________________________________ _________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


    ----==_mimepart_6898a9938c063_f22012b538a7b399c12567
    Content-Type: text/html; charset=us-ascii
    Content-Transfer-Encoding: 7bit

    <!DOCTYPE html>
    <html>
    <head>
    <meta charset="UTF-8">
    <title>New Defects Reported - Synchronet</title>
    <style>
    body { font-family: Arial, sans-serif; color: #222; line-height: 1.6; }
    .button {
    display: inline-block;
    padding: 10px 20px;
    margin: 20px 0;
    font-size: 16px;
    color: #fff !important;
    background-color: #0056b3;
    text-decoration: none;
    border-radius: 5px;
    }
    pre {
    background: #f8f9fa;
    padding: 10px;
    border-radius: 5px;
    font-size: 14px;
    overflow-x: auto;
    }
    </style>
    </head>
    <body>
    <p>Hi,</p>

    <p>
    Please find the latest report on new defect(s) introduced to <strong>Synchronet</strong>
    found with Coverity Scan.
    </p>

    <ul>
    <li><strong>New Defects Found:</strong> 1</li>
    <li>
    3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
    </li>
    <li><strong>Defects Shown:</strong> Showing 1 of 1 defect(s)</li>
    </ul>

    <h3>Defect Details</h3>
    <pre>
    ** CID 583942: High impact quality (Y2K38_SAFETY)
    /userdat.c: 3171 in loginuserdat()


    _______________________________________________________________________________ ______________
    *** CID 583942: High impact quality (Y2K38_SAFETY)
    /userdat.c: 3171 in loginuserdat()
    3165 if (protocol != NULL)
    3166 SAFECOPY(user-&gt;connection, protocol);
    3167 if (hostname != NULL)
    3168 SAFECOPY(user-&gt;comp, hostname);
    3169 if (ipaddr != NULL)
    3170 SAFECOPY(user-&gt;ipaddr, ipaddr);
    &gt;&gt;&gt; CID 583942: High impact quality (Y2K38_SAFETY) &gt;&gt;&gt; A &quot;time_t&quot; value is stored in an integer with too few bits to accommodate it. The expression &quot;logontime&quot; is cast to &quot;time32_t&quot;.
    3171 user-&gt;logontime = logontime;
    3172
    3173 return putuserdat(cfg, user);
    3174 }
    3175
    3176 /****************************************************************************/

    </pre>

    <p>
    <a href="https://scan.coverity.com/projects/synchronet?tab=overview" class="button">View Defects in Coverity Scan</a>
    </p>

    <p>Best regards,</p>
    <p>The Coverity Scan Admin Team</p>
    <img class="logo" width="140" src="https://scan.coverity.com/assets/BlackDuck Logo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg" /> </body>
    </html>
    ----==_mimepart_6898a9938c063_f22012b538a7b399c12567--


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Mon Aug 11 13:57:59 2025
    ----==_mimepart_6899f6e6bbda6_101b942b538a7b399c1257b
    Content-Type: text/plain; charset=us-ascii
    Content-Transfer-Encoding: 7bit

    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 583999: (UNINIT)


    _______________________________________________________________________________ ______________
    *** CID 583999: (UNINIT)
    /file.cpp: 182 in sbbs_t::removefcdt(smbmsg_t *)()
    176 if (cfg.dir[f->dir]->misc & DIR_CDTUL)
    177 cdt = ((ulong)(f->cost * (cfg.dir[f->dir]->up_pct / 100.0)) / cur_cps) / 60;
    178 if (cfg.dir[f->dir]->misc & DIR_CDTDL
    179 && f->hdr.times_downloaded) /* all downloads */ 180 cdt += ((ulong)((long)f->hdr.times_downloaded 181 * f->cost * (cfg.dir[f->dir]->dn_pct / 100.0)) / cur_cps) / 60;
    CID 583999: (UNINIT)
    Using uninitialized value "user.level" when calling "adjustuserval". 182 adjustuserval(&cfg, &user, USER_MIN, -cdt);
    183 snprintf(str, sizeof str, "%lu minute", cdt);
    184 snprintf(tmp, sizeof tmp, text[FileRemovedUserMsg]
    185 , f->name, cdt ? str : text[No]);
    186 putsmsg(user.number, tmp);
    187 }
    /file.cpp: 203 in sbbs_t::removefcdt(smbmsg_t *)()
    197 bprintf(text[CreditsToRemove], f->from);
    198 getstr(str, 10, K_NUMBER | K_LINE | K_EDIT | K_AUTODEL);
    199 if (msgabort(true))
    200 return false;
    201 cdt = atol(str);
    202 }
    CID 583999: (UNINIT)
    Using uninitialized value "user.level" when calling "adjustuserval". 203 adjustuserval(&cfg, &user, USER_CDT, -cdt);
    204 snprintf(tmp, sizeof tmp, text[FileRemovedUserMsg]
    205 , f->name, cdt > 0 ? ultoac(cdt, str) : text[No]);
    206 putsmsg(user.number, tmp);
    207 }
    208
    /file.cpp: 209 in sbbs_t::removefcdt(smbmsg_t *)()
    203 adjustuserval(&cfg, &user, USER_CDT, -cdt);
    204 snprintf(tmp, sizeof tmp, text[FileRemovedUserMsg]
    205 , f->name, cdt > 0 ? ultoac(cdt, str) : text[No]);
    206 putsmsg(user.number, tmp);
    207 }
    208
    CID 583999: (UNINIT)
    Using uninitialized value "user.level" when calling "adjustuserval". 209 adjustuserval(&cfg, &user, USER_ULB, -f->size);
    210 adjustuserval(&cfg, &user, USER_ULS, -1);
    211 return true;
    212 }
    213
    214 /****************************************************************************/ /file.cpp: 210 in sbbs_t::removefcdt(smbmsg_t *)()
    204 snprintf(tmp, sizeof tmp, text[FileRemovedUserMsg]
    205 , f->name, cdt > 0 ? ultoac(cdt, str) : text[No]);
    206 putsmsg(user.number, tmp);
    207 }
    208
    209 adjustuserval(&cfg, &user, USER_ULB, -f->size);
    CID 583999: (UNINIT)
    Using uninitialized value "user.level" when calling "adjustuserval". 210 adjustuserval(&cfg, &user, USER_ULS, -1);
    211 return true;
    212 }
    213
    214 /****************************************************************************/ 215 /****************************************************************************/


    _______________________________________________________________________________ _________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


    ----==_mimepart_6899f6e6bbda6_101b942b538a7b399c1257b
    Content-Type: text/html; charset=us-ascii
    Content-Transfer-Encoding: 7bit

    <!DOCTYPE html>
    <html>
    <head>
    <meta charset="UTF-8">
    <title>New Defects Reported - Synchronet</title>
    <style>
    body { font-family: Arial, sans-serif; color: #222; line-height: 1.6; }
    .button {
    display: inline-block;
    padding: 10px 20px;
    margin: 20px 0;
    font-size: 16px;
    color: #fff !important;
    background-color: #0056b3;
    text-decoration: none;
    border-radius: 5px;
    }
    pre {
    background: #f8f9fa;
    padding: 10px;
    border-radius: 5px;
    font-size: 14px;
    overflow-x: auto;
    }
    </style>
    </head>
    <body>
    <p>Hi,</p>

    <p>
    Please find the latest report on new defect(s) introduced to <strong>Synchronet</strong>
    found with Coverity Scan.
    </p>

    <ul>
    <li><strong>New Defects Found:</strong> 1</li>
    <li><strong>Defects Shown:</strong> Showing 1 of 1 defect(s)</li>
    </ul>

    <h3>Defect Details</h3>
    <pre>
    ** CID 583999: (UNINIT)


    _______________________________________________________________________________ ______________
    *** CID 583999: (UNINIT)
    /file.cpp: 182 in sbbs_t::removefcdt(smbmsg_t *)()
    176 if (cfg.dir[f-&gt;dir]-&gt;misc &amp; DIR_CDTUL)
    177 cdt = ((ulong)(f-&gt;cost * (cfg.dir[f-&gt;dir]-&gt;up_pct / 100.0)) / cur_cps) / 60;
    178 if (cfg.dir[f-&gt;dir]-&gt;misc &amp; DIR_CDTDL
    179 &amp;&amp; f-&gt;hdr.times_downloaded) /* all downloads */
    180 cdt += ((ulong)((long)f-&gt;hdr.times_downloaded
    181 * f-&gt;cost * (cfg.dir[f-&gt;dir]-&gt;dn_pct / 100.0)) / cur_cps) / 60;
    &gt;&gt;&gt; CID 583999: (UNINIT)
    &gt;&gt;&gt; Using uninitialized value &quot;user.level&quot; when calling &quot;adjustuserval&quot;.
    182 adjustuserval(&amp;cfg, &amp;user, USER_MIN, -cdt);
    183 snprintf(str, sizeof str, &quot;%lu minute&quot;, cdt); 184 snprintf(tmp, sizeof tmp, text[FileRemovedUserMsg]
    185 , f-&gt;name, cdt ? str : text[No]);
    186 putsmsg(user.number, tmp);
    187 }
    /file.cpp: 203 in sbbs_t::removefcdt(smbmsg_t *)()
    197 bprintf(text[CreditsToRemove], f-&gt;from);
    198 getstr(str, 10, K_NUMBER | K_LINE | K_EDIT | K_AUTODEL);
    199 if (msgabort(true))
    200 return false;
    201 cdt = atol(str);
    202 }
    &gt;&gt;&gt; CID 583999: (UNINIT)
    &gt;&gt;&gt; Using uninitialized value &quot;user.level&quot; when calling &quot;adjustuserval&quot;.
    203 adjustuserval(&amp;cfg, &amp;user, USER_CDT, -cdt);
    204 snprintf(tmp, sizeof tmp, text[FileRemovedUserMsg]
    205 , f-&gt;name, cdt &gt; 0 ? ultoac(cdt, str) : text[No]);
    206 putsmsg(user.number, tmp);
    207 }
    208
    /file.cpp: 209 in sbbs_t::removefcdt(smbmsg_t *)()
    203 adjustuserval(&amp;cfg, &amp;user, USER_CDT, -cdt);
    204 snprintf(tmp, sizeof tmp, text[FileRemovedUserMsg]
    205 , f-&gt;name, cdt &gt; 0 ? ultoac(cdt, str) : text[No]);
    206 putsmsg(user.number, tmp);
    207 }
    208
    &gt;&gt;&gt; CID 583999: (UNINIT)
    &gt;&gt;&gt; Using uninitialized value &quot;user.level&quot; when calling &quot;adjustuserval&quot;.
    209 adjustuserval(&amp;cfg, &amp;user, USER_ULB, -f-&gt;size);
    210 adjustuserval(&amp;cfg, &amp;user, USER_ULS, -1);
    211 return true;
    212 }
    213
    214 /****************************************************************************/ /file.cpp: 210 in sbbs_t::removefcdt(smbmsg_t *)()
    204 snprintf(tmp, sizeof tmp, text[FileRemovedUserMsg]
    205 , f-&gt;name, cdt &gt; 0 ? ultoac(cdt, str) : text[No]);
    206 putsmsg(user.number, tmp);
    207 }
    208
    209 adjustuserval(&amp;cfg, &amp;user, USER_ULB, -f-&gt;size); &gt;&gt;&gt; CID 583999: (UNINIT)
    &gt;&gt;&gt; Using uninitialized value &quot;user.level&quot; when calling &quot;adjustuserval&quot;.
    210 adjustuserval(&amp;cfg, &amp;user, USER_ULS, -1);
    211 return true;
    212 }
    213
    214 /****************************************************************************/ 215 /****************************************************************************/

    </pre>

    <p>
    <a href="https://scan.coverity.com/projects/synchronet?tab=overview" class="button">View Defects in Coverity Scan</a>
    </p>

    <p>Best regards,</p>
    <p>The Coverity Scan Admin Team</p>
    <img class="logo" width="140" src="https://scan.coverity.com/assets/BlackDuck Logo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg" /> </body>
    </html>
    ----==_mimepart_6899f6e6bbda6_101b942b538a7b399c1257b--


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Mon Aug 18 13:37:12 2025
    ----==_mimepart_68a32c876d3fd_16fcff2e2b69fdf990236c2
    Content-Type: text/plain; charset=us-ascii
    Content-Transfer-Encoding: 7bit

    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 584091: (Y2K38_SAFETY)
    /logon.cpp: 631 in sbbs_t::logonstats()()
    /logon.cpp: 642 in sbbs_t::logonstats()()
    /logon.cpp: 638 in sbbs_t::logonstats()()


    _______________________________________________________________________________ ______________
    *** CID 584091: (Y2K38_SAFETY)
    /logon.cpp: 631 in sbbs_t::logonstats()()
    625 errormsg(WHERE, ERR_READ, "system stats");
    626 return 0;
    627 }
    628
    629 now = time(NULL);
    630 if (stats.date > now + (24L * 60L * 60L)) /* More than a day in the future? */
    CID 584091: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "stats.date" is cast to "int".
    631 errormsg(WHERE, ERR_CHK, "Daily stats date/time stamp", (int)stats.date);
    632
    633 if (!dates_are_same(now, stats.date)) {
    634
    635 struct tm tm{};
    636 struct tm update_tm{};
    /logon.cpp: 642 in sbbs_t::logonstats()()
    636 struct tm update_tm{};
    637 if (localtime_r(&stats.date, &update_tm) == NULL) {
    638 errormsg(WHERE, ERR_CHK, "Daily stats date/time break down", (int)stats.date);
    639 return 0;
    640 }
    641 if (localtime_r(&now, &tm) == NULL) {
    CID 584091: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "stats.date" is cast to "int".
    642 errormsg(WHERE, ERR_CHK, "Current date/time break down", (int)stats.date);
    643 return 0;
    644 }
    645
    646 sys_status |= SS_NEW_DAY;
    647 if (tm.tm_mon != update_tm.tm_mon)
    /logon.cpp: 638 in sbbs_t::logonstats()()
    632
    633 if (!dates_are_same(now, stats.date)) {
    634
    635 struct tm tm{};
    636 struct tm update_tm{};
    637 if (localtime_r(&stats.date, &update_tm) == NULL) {
    CID 584091: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "stats.date" is cast to "int".
    638 errormsg(WHERE, ERR_CHK, "Daily stats date/time break down", (int)stats.date);
    639 return 0;
    640 }
    641 if (localtime_r(&now, &tm) == NULL) {
    642 errormsg(WHERE, ERR_CHK, "Current date/time break down", (int)stats.date);
    643 return 0;


    _______________________________________________________________________________ _________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


    ----==_mimepart_68a32c876d3fd_16fcff2e2b69fdf990236c2
    Content-Type: text/html; charset=us-ascii
    Content-Transfer-Encoding: 7bit

    <!DOCTYPE html>
    <html>
    <head>
    <meta charset="UTF-8">
    <title>New Defects Reported - Synchronet</title>
    <style>
    body { font-family: Arial, sans-serif; color: #222; line-height: 1.6; }
    .button {
    display: inline-block;
    padding: 10px 20px;
    margin: 20px 0;
    font-size: 16px;
    color: #fff !important;
    background-color: #0056b3;
    text-decoration: none;
    border-radius: 5px;
    }
    pre {
    background: #f8f9fa;
    padding: 10px;
    border-radius: 5px;
    font-size: 14px;
    overflow-x: auto;
    }
    </style>
    </head>
    <body>
    <p>Hi,</p>

    <p>
    Please find the latest report on new defect(s) introduced to <strong>Synchronet</strong>
    found with Coverity Scan.
    </p>

    <ul>
    <li><strong>New Defects Found:</strong> 1</li>
    <li><strong>Defects Shown:</strong> Showing 1 of 1 defect(s)</li>
    </ul>

    <h3>Defect Details</h3>
    <pre>
    ** CID 584091: (Y2K38_SAFETY)
    /logon.cpp: 631 in sbbs_t::logonstats()()
    /logon.cpp: 642 in sbbs_t::logonstats()()
    /logon.cpp: 638 in sbbs_t::logonstats()()


    _______________________________________________________________________________ ______________
    *** CID 584091: (Y2K38_SAFETY)
    /logon.cpp: 631 in sbbs_t::logonstats()()
    625 errormsg(WHERE, ERR_READ, &quot;system stats&quot;); 626 return 0;
    627 }
    628
    629 now = time(NULL);
    630 if (stats.date &gt; now + (24L * 60L * 60L)) /* More than a day in the future? */
    &gt;&gt;&gt; CID 584091: (Y2K38_SAFETY)
    &gt;&gt;&gt; A &quot;time_t&quot; value is stored in an integer with too few bits to accommodate it. The expression &quot;stats.date&quot; is cast to &quot;int&quot;.
    631 errormsg(WHERE, ERR_CHK, &quot;Daily stats date/time stamp&quot;, (int)stats.date);
    632
    633 if (!dates_are_same(now, stats.date)) {
    634
    635 struct tm tm{};
    636 struct tm update_tm{};
    /logon.cpp: 642 in sbbs_t::logonstats()()
    636 struct tm update_tm{};
    637 if (localtime_r(&amp;stats.date, &amp;update_tm) == NULL) {
    638 errormsg(WHERE, ERR_CHK, &quot;Daily stats date/time break down&quot;, (int)stats.date);
    639 return 0;
    640 }
    641 if (localtime_r(&amp;now, &amp;tm) == NULL) { &gt;&gt;&gt; CID 584091: (Y2K38_SAFETY)
    &gt;&gt;&gt; A &quot;time_t&quot; value is stored in an integer with too few bits to accommodate it. The expression &quot;stats.date&quot; is cast to &quot;int&quot;.
    642 errormsg(WHERE, ERR_CHK, &quot;Current date/time break down&quot;, (int)stats.date);
    643 return 0;
    644 }
    645
    646 sys_status |= SS_NEW_DAY;
    647 if (tm.tm_mon != update_tm.tm_mon)
    /logon.cpp: 638 in sbbs_t::logonstats()()
    632
    633 if (!dates_are_same(now, stats.date)) {
    634
    635 struct tm tm{};
    636 struct tm update_tm{};
    637 if (localtime_r(&amp;stats.date, &amp;update_tm) == NULL) {
    &gt;&gt;&gt; CID 584091: (Y2K38_SAFETY)
    &gt;&gt;&gt; A &quot;time_t&quot; value is stored in an integer with too few bits to accommodate it. The expression &quot;stats.date&quot; is cast to &quot;int&quot;.
    638 errormsg(WHERE, ERR_CHK, &quot;Daily stats date/time break down&quot;, (int)stats.date);
    639 return 0;
    640 }
    641 if (localtime_r(&amp;now, &amp;tm) == NULL) {
    642 errormsg(WHERE, ERR_CHK, &quot;Current date/time break down&quot;, (int)stats.date);
    643 return 0;

    </pre>

    <p>
    <a href="https://scan.coverity.com/projects/synchronet?tab=overview" class="button">View Defects in Coverity Scan</a>
    </p>

    <p>Best regards,</p>
    <p>The Coverity Scan Admin Team</p>
    <img class="logo" width="140" src="https://scan.coverity.com/assets/BlackDuck Logo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg" /> </body>
    </html>
    ----==_mimepart_68a32c876d3fd_16fcff2e2b69fdf990236c2--


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Mon Sep 1 03:04:51 2025
    ----==_mimepart_68b50d534c480_2468dc2e83776d99ac35483
    Content-Type: text/plain; charset=us-ascii
    Content-Transfer-Encoding: 7bit

    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 584833: Error handling issues (CHECKED_RETURN)


    _______________________________________________________________________________ ______________
    *** CID 584833: Error handling issues (CHECKED_RETURN)
    /mailsrvr.c: 2877 in archive_mail()
    2871 bool archive_mail(const char* fname, int usernumber, const char* subdir, const char* session_id)
    2872 {
    2873 char tmp[128];
    2874 char path[MAX_PATH + 1];
    2875
    2876 snprintf(path, sizeof path, "%suser/%04u/%s/", scfg.data_dir, usernumber, subdir);
    CID 584833: Error handling issues (CHECKED_RETURN)
    Calling "mkpath(path)" without checking return value. It wraps a library function that may fail and return an error code.
    2877 mkpath(path);
    2878 SAFECAT(path, gmtime_to_isoDateTimeStr(time(NULL), tmp, sizeof tmp));
    2879 SAFECAT(path, "-");
    2880 SAFECAT(path, session_id);
    2881 SAFECAT(path, ".eml");
    2882 return CopyFile(fname, path, /* fail-if-exists: */true);


    _______________________________________________________________________________ _________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


    ----==_mimepart_68b50d534c480_2468dc2e83776d99ac35483
    Content-Type: text/html; charset=us-ascii
    Content-Transfer-Encoding: 7bit

    <!DOCTYPE html>
    <html>
    <head>
    <meta charset="UTF-8">
    <title>New Defects Reported - Synchronet</title>
    <style>
    body { font-family: Arial, sans-serif; color: #222; line-height: 1.6; }
    .button {
    display: inline-block;
    padding: 10px 20px;
    margin: 20px 0;
    font-size: 16px;
    color: #fff !important;
    background-color: #0056b3;
    text-decoration: none;
    border-radius: 5px;
    }
    pre {
    background: #f8f9fa;
    padding: 10px;
    border-radius: 5px;
    font-size: 14px;
    overflow-x: auto;
    }
    </style>
    </head>
    <body>
    <p>Hi,</p>

    <p>
    Please find the latest report on new defect(s) introduced to <strong>Synchronet</strong>
    found with Coverity Scan.
    </p>

    <ul>
    <li><strong>New Defects Found:</strong> 1</li>
    <li><strong>Defects Shown:</strong> Showing 1 of 1 defect(s)</li>
    </ul>

    <h3>Defect Details</h3>
    <pre>
    ** CID 584833: Error handling issues (CHECKED_RETURN)


    _______________________________________________________________________________ ______________
    *** CID 584833: Error handling issues (CHECKED_RETURN)
    /mailsrvr.c: 2877 in archive_mail()
    2871 bool archive_mail(const char* fname, int usernumber, const char* subdir, const char* session_id)
    2872 {
    2873 char tmp[128];
    2874 char path[MAX_PATH + 1];
    2875
    2876 snprintf(path, sizeof path, &quot;%suser/%04u/%s/&quot;, scfg.data_dir, usernumber, subdir);
    &gt;&gt;&gt; CID 584833: Error handling issues (CHECKED_RETURN) &gt;&gt;&gt; Calling &quot;mkpath(path)&quot; without checking return value. It wraps a library function that may fail and return an error code.
    2877 mkpath(path);
    2878 SAFECAT(path, gmtime_to_isoDateTimeStr(time(NULL), tmp, sizeof tmp));
    2879 SAFECAT(path, &quot;-&quot;);
    2880 SAFECAT(path, session_id);
    2881 SAFECAT(path, &quot;.eml&quot;);
    2882 return CopyFile(fname, path, /* fail-if-exists: */true);

    </pre>

    <p>
    <a href="https://scan.coverity.com/projects/synchronet?tab=overview" class="button">View Defects in Coverity Scan</a>
    </p>

    <p>Best regards,</p>
    <p>The Coverity Scan Admin Team</p>
    <img class="logo" width="140" src="https://scan.coverity.com/assets/BlackDuck Logo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg" /> </body>
    </html>
    ----==_mimepart_68b50d534c480_2468dc2e83776d99ac35483--


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net